Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new section for span ID remapper #26865

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

mervebolatdd
Copy link
Contributor

The screenshot will be updated when https://datadoghq.atlassian.net/browse/LOGSAC-763 is completed.

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@mervebolatdd mervebolatdd marked this pull request as ready for review January 3, 2025 09:42
@mervebolatdd mervebolatdd requested a review from a team as a code owner January 3, 2025 09:42
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor feedback. Also, the image link is broken, but I think that's because your branch is behind master. I'll go ahead and merge latest from master to see if that fixes the issue.

@drichards-87
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 3, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-03 17:45:11 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 7m.


2025-01-03 17:51:54 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 3cefd0c into master Jan 3, 2025
17 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the mervebolat/new-section-for-span-remapper branch January 3, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants